Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds/ec2_instance_type_offering locations: Add locations attribute #16704

Merged
merged 6 commits into from
Jul 23, 2021
Merged

ds/ec2_instance_type_offering locations: Add locations attribute #16704

merged 6 commits into from
Jul 23, 2021

Conversation

orgito
Copy link
Contributor

@orgito orgito commented Dec 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16703

Release note for CHANGELOG:

aws_ec2_instance_type_offerings - add locations attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@orgito orgito requested a review from a team as a code owner December 10, 2020 20:48
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 10, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 10, 2020
@orgito orgito mentioned this pull request Dec 10, 2020
Closed
github-actions[bot]
github-actions bot reviewed Dec 10, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @orgito 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@orgito orgito changed the title ds/ec2 instance type offering locations: Returns a locations field (WIP) ds/ec2 instance type offering locations: Add locations attribute (WIP) Dec 10, 2020
@orgito orgito changed the title ds/ec2 instance type offering locations: Add locations attribute (WIP) ds/ec2_instance_type_offering locations: Add locations attribute (WIP) Dec 10, 2020
@orgito orgito changed the title ds/ec2_instance_type_offering locations: Add locations attribute (WIP) ds/ec2_instance_type_offering locations: Add locations attribute Dec 10, 2020
@orgito orgito force-pushed the ds/ec2_instance_type_offering-locations branch from 0b0c6e4 to 3fae369 Compare December 11, 2020 04:41
Base automatically changed from master to main January 23, 2021 00:59
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 23, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 23, 2021
@ewbankkit ewbankkit mentioned this pull request Jul 23, 2021
Closed
ewbankkit
ewbankkit approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSEc2InstanceTypeOfferingsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2InstanceTypeOfferingsDataSource_ -timeout 180m
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== RUN   TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== PAUSE TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter
=== CONT  TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (9.89s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (11.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.649s

@ewbankkit ewbankkit force-pushed the ds/ec2_instance_type_offering-locations branch from 8253a62 to 383202e Compare July 23, 2021 15:45
@ewbankkit
Copy link
Contributor

@orgito Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2cff58c into hashicorp:main Jul 23, 2021
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 23, 2021
@ewbankkit ewbankkit mentioned this pull request Jul 23, 2021
Closed
@orgito orgito deleted the ds/ec2_instance_type_offering-locations branch July 23, 2021 23:27
@ewbankkit ewbankkit mentioned this pull request Jul 25, 2021
Merged
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.

aws_ec2_instance_type_offerings should return the locations
3 participants
@orgito @ewbankkit @mjulianotq